Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling bold / italics with toolbar spawns more * if inner text is selected, not outer #71

Closed
CosmoMyzrailGorynych opened this issue Feb 3, 2018 · 1 comment

Comments

@CosmoMyzrailGorynych
Copy link

Version

1.0.2

Test Environment

Firefox Developer Edition (latest), nw.js (webkit latest).

Current Behavior

  1. Go to https://nhnent.github.io/tui.editor/ , find an editor with a code input.
  2. Write **bold**
  3. Double-click the bold. Note that only bold gets selected, not **bold**.
  4. Click a Bold button on a toolbar.
  5. Now you have ****bold****.

These __bolds__ are selected with underscores on double-clicking, and their formatting is removed correctly. But if exactly bolds are selected, it creates more symbols as well.

The same affects *italics*.

Expected Behavior

You should get bold on step 5. Code editor should check for surrounding asterisks.

@kyuwoo-choi kyuwoo-choi added the Enhancement Enhance performance or improve usability of original features. label Feb 19, 2018
@sohee-lee7 sohee-lee7 added Bug Category: Style P 1 and removed Enhancement Enhance performance or improve usability of original features. labels Feb 21, 2019
@sohee-lee7
Copy link
Contributor

This issue is same #434 and that is fixed. So I close this issue.

seonim-ryu pushed a commit that referenced this issue Feb 5, 2020
seonim-ryu pushed a commit that referenced this issue Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants