Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default font style to viewer (fix #1045) #1048

Merged
merged 1 commit into from Jun 15, 2020
Merged

fix: add default font style to viewer (fix #1045) #1048

merged 1 commit into from Jun 15, 2020

Conversation

seonim-ryu
Copy link
Member

@seonim-ryu seonim-ryu commented Jun 15, 2020 •
edited

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu seonim-ryu force-pushed the fix/apply-default-font-viewer branch from 4239902 to e67bd95 Compare June 15, 2020 02:34
@seonim-ryu seonim-ryu requested a review from js87zz June 15, 2020 02:36
js87zz
js87zz approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seonim-ryu seonim-ryu merged commit 5ec7db0 into master Jun 15, 2020
@seonim-ryu seonim-ryu deleted the fix/apply-default-font-viewer branch June 16, 2020 10:46
js87zz pushed a commit that referenced this pull request Jun 17, 2021
@seonim-ryu
refactor: all dist namespace to tui.Editor (fix #1048)
894ef99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seonim-ryu @js87zz