fix: broken test case to sanitize on-event in ie #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonim-ryu
commented
Jun 15, 2020
| @@ -54,7 +54,7 @@ describe('htmlSanitizer', function() { | |||
| expect(htmlSanitizer(`<TABLE BACKGROUND="javascript:alert('XSS')">`, true)).toBe( | |||
| '<table></table>' | |||
| ); | |||
| expect(htmlSanitizer(`<TABLE><TD BACKGROUND="javascript:alert('XSS')">`, true)).toBe( | |||
| expect(htmlSanitizer(`<TABLE><TD BACKGROUND="javascript:alert('XSS')"></TD>`, true)).toBe( | |||
There was a problem hiding this comment.
IE10์์ <td>๋ง ๋๊ฒจ์ค ๊ฒฝ์ฐ, ์๋์ผ๋ก ํด๋ก์ฆ ํ๊ทธ๋ฅผ ์์ฑํด์ฃผ์ง ์์์ ํด๋ก์ฆ ํ๊ทธ๋ฅผ ์ถ๊ฐํจ
seonim-ryu
commented
Jun 15, 2020
Comment on lines
+101
to
+103
| if (ON_EVENT_RX.test(name)) { | ||
| node[name] = null; | ||
| } |
There was a problem hiding this comment.
IE์ ๊ฒฝ์ฐonload, onerror ๋ฑ ์์ฑ์ ํ ๋น๋ ์ด๋ฒคํธ๊ฐ ์ ๊ฑฐ๋์ง ์์์ XSS ์คํฌ๋ฆฝํธ๋ฅผ ์คํ์ํค๋ ๊ฒฝ์ฐ๊ฐ ์์ผ๋ฉฐ ์ด๋ฒคํธ๋ฅผ ์์ ํ๊ฒ ์ ๊ฑฐํ๊ธฐ ์ํด์ ํด๋น ๋ก์ง์ ์ถ๊ฐํจ
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
getNamedItem,removeNamedItemtogetAttribute,removeAttributebecause IE is not supported correctly.Thank you for your contribution to TOAST UI product. ๐ ๐ โจ