Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve english expression (fix #131) #138

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
2 participants
@jjangga0214
Copy link
Contributor

commented Apr 8, 2018

Please check if the PR fulfills these requirements

  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

By the way..

In my opinion, it would be more consistent if the title of PR uses (fixes #xxx) rather than (fix #xxx). For instance, eslint uses (fixes #xxx) both on commit message and PR title. Of course, it fully depends on cultures and is quite hard to change in mature, traditional convention. But as tui.editor is pretty new, it might be adequate time to update the policy.

@kyuwoo-choi

This comment has been minimized.

Copy link
Member

commented Apr 9, 2018

Thank you for your contribution @jjangga0214 🎉
I'm merging it.

@kyuwoo-choi kyuwoo-choi merged commit e018128 into nhn:master Apr 9, 2018

@jjangga0214 jjangga0214 deleted the jjangga0214:docs branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.