docs: improve english expression (fix #131) #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @jjangga0214 🎉 |
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 2, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 2, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 6, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Feb 5, 2020
Thanks to @gertsonderby who pointed these out in #138.
seonim-ryu
pushed a commit
that referenced
this pull request
Feb 5, 2020
Thanks to @gertsonderby who pointed these out in #138.
js87zz
pushed a commit
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)By the way..
In my opinion, it would be more consistent if the title of PR uses
(fixes #xxx)rather than(fix #xxx). For instance, eslint uses(fixes #xxx)both on commit message and PR title. Of course, it fully depends on cultures and is quite hard to change in mature, traditional convention. But as tui.editor is pretty new, it might be adequate time to update the policy.