Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file upload button type #1585

Merged
merged 1 commit into from Jun 21, 2021
Merged

fix: file upload button type #1585

merged 1 commit into from Jun 21, 2021

Conversation

subicura
Copy link
Contributor

@subicura subicura commented Jun 17, 2021 •
edited

fix #1584

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Fix file upload button submit issue.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@subicura subicura changed the title fix: file upload button type (fix #1584) fix: file upload button type Jun 18, 2021
@jalyna
Copy link

jalyna commented Jun 18, 2021

thank you! looking forward to this fix

js87zz
js87zz approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subicura
Thanks!! :)

@js87zz js87zz merged commit 33ee07f into nhn:master Jun 21, 2021
@js87zz
Copy link
Contributor

js87zz commented Jul 7, 2021

@subicura @jalyna
This PR has been released in v3.0.1.
Thanks!

ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@subicura
fix: set file upload button's type to button (nhn#1585)
fc3b2d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set "File Upload" Button type to "button"
3 participants
@subicura @jalyna @js87zz