Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the default addImageBlobHook is called even though it should have been deleted by hooks option #1623

Merged
merged 5 commits into from Jul 6, 2021
Merged

fix: the default addImageBlobHook is called even though it should have been deleted by hooks option #1623

merged 5 commits into from Jul 6, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Jul 1, 2021 •
edited

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz mentioned this pull request Jul 1, 2021
Closed
lja1018
lja1018 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

apps/editor/src/__test__/unit/editor.spec.ts Outdated Show resolved Hide resolved
jwlee1108
jwlee1108 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@js87zz js87zz merged commit a677b6d into master Jul 6, 2021
@js87zz js87zz deleted the fix/addImageBlobHook branch July 6, 2021 02:15
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: the default addImageBlobHook is called even though it should h…
70b0f91 
…ave been deleted by `hooks` option (nhn#1623)

* fix: broken test case for popup widget

* fix: broken test case(due to focus timer)

* fix: hooks option cannot remove default hook event

* chore: add test case(`addHook` API, `hooks` option)

* chore: apply code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lja1018 lja1018 lja1018 approved these changes

@jwlee1108 jwlee1108 jwlee1108 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@js87zz @lja1018 @jwlee1108