Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: users cannot show the toolbar item when the editor is resized #1747

Merged
merged 3 commits into from Aug 12, 2021
Merged

fix: users cannot show the toolbar item when the editor is resized #1747

merged 3 commits into from Aug 12, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Aug 10, 2021

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

jwlee1108
jwlee1108 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

adhrinae
adhrinae reviewed Aug 11, 2021
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

apps/editor/src/ui/components/toolbar/toolbar.ts Show resolved Hide resolved
apps/editor/src/ui/components/toolbar/toolbar.ts Show resolved Hide resolved
lja1018
lja1018 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

jajugoguma
jajugoguma approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@jajugoguma jajugoguma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다!

@js87zz js87zz merged commit 87de165 into master Aug 12, 2021
@js87zz js87zz deleted the fix/resize-toolbar branch August 12, 2021 00:54
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: users cannot show the toolbar item when the editor is resized (n…
113c39a 
…hn#1747)

* chore: add resize-observer-polyfill dependency

* fix: re-layout the toolbar when toolbar is resized

* chore: apply code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhrinae adhrinae adhrinae left review comments

@lja1018 lja1018 lja1018 approved these changes

@jwlee1108 jwlee1108 jwlee1108 approved these changes

@jajugoguma jajugoguma jajugoguma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@js87zz @adhrinae @lja1018 @jwlee1108 @jajugoguma