Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fail to convert list having blockQuote with spaces to wysiwyg #1792

Merged
merged 2 commits into from Sep 7, 2021
Merged

fix: fail to convert list having blockQuote with spaces to wysiwyg #1792

merged 2 commits into from Sep 7, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Sep 6, 2021 •
edited

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

as-is
2021-09-06 12-32-29 2021-09-06 12_32_38

to-be
2021-09-06 12-31-51 2021-09-06 12_32_01

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

adhrinae
adhrinae approved these changes Sep 6, 2021
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

jwlee1108
jwlee1108 approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

lja1018
lja1018 approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

@js87zz js87zz merged commit 68a5f9f into master Sep 7, 2021
@js87zz js87zz deleted the fix/converting-with-space branch September 7, 2021 01:39
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: fail to convert list having blockQuote with spaces to wysiwyg (n…
4e8563a 
…hn#1792)

* fix: wrong wysiwyg listItem content property

* chore: add convertor test case(block nodes in list)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhrinae adhrinae adhrinae approved these changes

@lja1018 lja1018 lja1018 approved these changes

@jwlee1108 jwlee1108 jwlee1108 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@js87zz @adhrinae @lja1018 @jwlee1108