fix: wrong popup in markdown preview (close #210) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyuwoo-choi
force-pushed
the
fix/wrong_popup_in_markdown_preview
branch
from
6f9223a
to
ef3fcc4
Compare
seonim-ryu
reviewed
Jun 18, 2018
| @@ -255,6 +257,8 @@ class EventManager { | |||
| if (handler.namespace !== namespace) { | |||
| handlersToSurvive.push(handler); | |||
| } | |||
|
|
|||
| return null; | |||
There was a problem hiding this comment.
주석 변경되어야겠네요~ (프라이빗이라 별 의미없어보이지만요 ;ㅅ;)
{?string}
There was a problem hiding this comment.
내부의 애로우 함수라 주석과 무관합니다.
|
[6/18] 리뷰 완료하였습니다. |
|
리뷰 완료하였습니다. 수고하셨습니다. |
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 2, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 2, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Jan 6, 2020
seonim-ryu
pushed a commit
that referenced
this pull request
Feb 5, 2020
…rmat-values Update README and Tests
seonim-ryu
pushed a commit
that referenced
this pull request
Feb 5, 2020
…rmat-values Update README and Tests
js87zz
pushed a commit
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
#210
Enabling/Disabling button feature is added to resolve the issue.
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨