Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong Type Definition, "rowHeaders" of IGridOptions index.d.ts #321

Closed
BillionaireDY opened this issue Apr 29, 2019 · 2 comments
Closed
Labels
Milestone

Comments

@BillionaireDY
Copy link
Contributor

Version

3.6.0

Development Environment

mac, chrome

Current Behavior

as is

    interface IGridOptions {
      ...
        rowHeaders?: IRowHeadersOptions; 
      ...
    }

to be

    interface IGridOptions {
      ...
        rowHeaders?: string[] | IRowHeadersOptions[]; 
      ...
    }

Expected Behavior

The rowHeaders of IGridOptions of index.d.ts is defined differently from the document.

image

@BillionaireDY BillionaireDY changed the title Wrong Type Definition: "rowHeaders" of IGridOptions index.d.ts fix: Wrong Type Definition, "rowHeaders" of IGridOptions index.d.ts Apr 29, 2019
@dongwoo-kim dongwoo-kim added the Bug label May 2, 2019
@dongwoo-kim dongwoo-kim added this to the 3.8.0 milestone May 2, 2019
@dongwoo-kim
Copy link

Thanks for the reporting. Your PR is merged into master branch and will be released in v3.8.0.

@BillionaireDY
Copy link
Contributor Author

Appreciate for your review and merging this issue 👍🏽🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants