Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type definition. rowHeaders of IGridOptions of index.d.ts #321 #322

Merged
merged 1 commit into from
May 2, 2019

Conversation

BillionaireDY
Copy link
Contributor

@BillionaireDY BillionaireDY commented Apr 29, 2019

fix: wrong type definition (ref #321)

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

The rowHeaders of IGridOptions of index.d.ts is defined differently from the document.
ref) #321


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jung-han
Copy link
Member

Can one of the admins verify this patch?

@jung-han jung-han self-requested a review May 2, 2019 08:00
Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. We are going to apply this PR in the v3.8.0. 🤟

@jung-han
Copy link
Member

jung-han commented May 2, 2019

ok to test

@jung-han jung-han merged commit 9990183 into nhn:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants