Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot show the dummy cells at the farthest right in scrollX #1312

Merged
merged 5 commits into from Apr 15, 2021
Merged

fix: cannot show the dummy cells at the farthest right in scrollX #1312

merged 5 commits into from Apr 15, 2021

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Apr 14, 2021

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

jung-han
jung-han approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료입니다~

shiren
shiren approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@shiren shiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

packages/toast-ui.grid/cypress/integration/dummyRows.spec.ts Outdated
cy.getByCls('cell-dummy').should('exist');
});

it('should inialize focus and selection layer', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize

lja1018
lja1018 approved these changes Apr 15, 2021
View reviewed changes
Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료입니다.

jungeun-cho
jungeun-cho approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@jungeun-cho jungeun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

dotaitch
dotaitch approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@dotaitch dotaitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@js87zz js87zz force-pushed the fix/wrong-calculating-position branch from 36ac08f to cf67b21 Compare April 15, 2021 07:54
@js87zz js87zz merged commit 2a8fffc into master Apr 15, 2021
@js87zz js87zz deleted the fix/wrong-calculating-position branch April 15, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiren shiren shiren approved these changes

@dotaitch dotaitch dotaitch approved these changes

@lja1018 lja1018 lja1018 approved these changes

@jung-han jung-han jung-han approved these changes

@jungeun-cho jungeun-cho jungeun-cho approved these changes

@dongsik-yoo dongsik-yoo Awaiting requested review from dongsik-yoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@js87zz @shiren @dotaitch @lja1018 @jung-han @jungeun-cho