fix: wrong filter layer position #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js87zz
requested review from
dongsik-yoo,
dotaitch,
jungeun-cho,
lja1018 and
shiren
lja1018
approved these changes
Apr 23, 2021
| const { innerWidth } = window; | ||
|
|
||
| if (innerWidth < left + clientWidth) { | ||
| const orgLeft = this.state.left; |
There was a problem hiding this comment.
넵 맞습니다~그리드에서 이런식으로 많이 사용합니다.
… is smaller than the filter layer left position
js87zz
force-pushed
the
fix/filter-layer-position
branch
from
ced4de5
to
ea71c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
as-is
to-be
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨