fix: emit script error when copying unobservable rows #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js87zz
requested review from
jungeun-cho,
jung-han,
dongsik-yoo,
dotaitch,
lja1018 and
shiren
jung-han
approved these changes
Apr 26, 2021
jungeun-cho
approved these changes
Apr 26, 2021
| @@ -87,7 +87,7 @@ export function updateHeights(store: Store) { | |||
| : filteredRawData.map((row) => getRowHeight(row, rowHeight)); | |||
| } | |||
|
|
|||
| export function makeObservable(store: Store, rowIndex: number) { | |||
| export function makeObservable(store: Store, rowIndex: number, silent?: boolean) { | |||
There was a problem hiding this comment.
silent = false로 디폴트값을 설정해주는건어때요?
js87zz
force-pushed
the
fix/copy-all-rows
branch
from
c7e43d2
to
3629b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨