Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change filtered summary properly when no filter is set #1764

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Fixed an issue where the value of filtered in the summary value is not set properly when no filter is set.
    • It was caused by not updating the value unless the filter was set.
    • Fixed to return the same value as the default summary value if no filter is set.
  • In addition, the problem that min and max was not updated correctly when the data of cells that had values corresponding to min and max was changed has been �fixed.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@lja1018 lja1018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

@jajugoguma jajugoguma merged commit e78a1e9 into master Aug 9, 2022
@jajugoguma jajugoguma deleted the fix/not-update-filtered-summary branch August 9, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants