New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fit to parent height without padding (fix #1756) #1765

Merged

jajugoguma merged 1 commit into master from fix/fit-to-parent-not-work-properly

Aug 10, 2022

Contributor

jajugoguma commented Aug 10, 2022

Please check if the PR fulfills these requirements

It's submitted to right branch according to our branching model
It's right issue type on title
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
It does not introduce a breaking change or has description for the breaking change

Description

Fixed an issue where the height including the 'padding' of the parent element was set when the Grid's 'bodyHeight' was set to 'fitToParent'.
- This was caused by not subtracting the width of padding while setting the height using clientHeight which returns a value including padding.

As-Is

To-Be

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨


          fix: fit to parent height without padding

b5e5805

jwlee1108 approved these changes

View reviewed changes

adhrinae approved these changes

View reviewed changes

jajugoguma merged commit c3bd006 into master

jajugoguma deleted the fix/fit-to-parent-not-work-properly branch

August 10, 2022 08:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment