New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: too slow removeRows API #1815

Merged

jajugoguma merged 1 commit into master from fix/remove_rows_too_slow

Nov 8, 2022

Contributor

jajugoguma commented Nov 7, 2022

Please check if the PR fulfills these requirements

It's submitted to right branch according to our branching model
It's right issue type on title
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
It does not introduce a breaking change or has description for the breaking change

Description

Fixed an issue where removeRows API was too slow.
- It was slow because every time deleted a row, it iterates to update sortKey of all the data.
- So I fixed it to update `sortKey' after deleting all data.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨


          fix: too slow removeRows API

5421eac

jwlee1108 approved these changes

View reviewed changes

jajugoguma merged commit 4a21c47 into master

jajugoguma deleted the fix/remove_rows_too_slow branch

November 8, 2022 04:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment