New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter layer shows inside container #1860

Merged

jajugoguma merged 3 commits into master from fix/filter_layer_in_grid_container

Feb 17, 2023

Contributor

jajugoguma commented Feb 17, 2023

Please check if the PR fulfills these requirements

It's submitted to right branch according to our branching model
It's right issue type on title
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
It does not introduce a breaking change or has description for the breaking change

Description

Fixed the filter layer to appear inside the grid container.

As-Is

To-Be

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

jajugoguma added 2 commits

February 17, 2023 10:44


          fix: filter layer shows inside container

7c6fc8c


          test: add test for filter layer position

605c0b8

jajugoguma requested review from dotaitch, adhrinae, sunyoungBae and jwlee1108

February 17, 2023 02:27

jajugoguma self-assigned this

adhrinae suggested changes

View reviewed changes

packages/toast-ui.grid/cypress/integration/filter.spec.ts Outdated Show resolved Hide resolved


          test: remove unnecessary only

5a98a49

jwlee1108 approved these changes

View reviewed changes

jajugoguma requested a review from adhrinae

February 17, 2023 06:00

sunyoungBae approved these changes

View reviewed changes

adhrinae approved these changes

View reviewed changes

jajugoguma merged commit 55838a7 into master

jajugoguma deleted the fix/filter_layer_in_grid_container branch

February 17, 2023 07:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment