fix: filter input not reset on clear filter #1885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
Fixed an issue where the
input
element of a filter was not initialized when cleared without applying the filter.Unlike the
data
in the store, thefilterLayerState
is not observable. However, the TOAST UI Grid does not unfilter when no filter is applied. After all, the filter in the data does not change, so resetting thefilterLayeState
does not trigger a re-render.To properly reflect a resetting
filterLayerState
, I've changed it to call anotify
function to notify that the store has changed, causing a re-render.Thank you for your contribution to TOAST UI product. 🎉 😘 ✨