Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter input not reset on clear filter #1885

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Fixed an issue where the input element of a filter was not initialized when cleared without applying the filter.

Unlike the data in the store, the filterLayerState is not observable. However, the TOAST UI Grid does not unfilter when no filter is applied. After all, the filter in the data does not change, so resetting the filterLayeState does not trigger a re-render.

To properly reflect a resetting filterLayerState, I've changed it to call a notify function to notify that the store has changed, causing a re-render.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma merged commit 020a5fa into master Mar 17, 2023
@jajugoguma jajugoguma deleted the fix/filter_clear branch March 17, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants