Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing update history in DataManger #1919

Merged
merged 3 commits into from
May 26, 2023

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Fixed an issue where update history in DataManger was missing when using the setRows API.
    • This issue was caused by two mistakes.
      1. To efficiently update the update history, when looking for consecutive row indices, we checked for consecutive using the object itself, not the rowIndex property of the IndexedRow object.
      2. When removing old update history using consecutive rowIndexes of the rows being updated, the starting index was set without considering the number of previously deleted elements, resulting in incorrectly deleting old update history.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jajugoguma jajugoguma merged commit e19386e into master May 26, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the fix/missing_update_history branch May 26, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants