Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move the scroll position on calling focus, focusAtAPI(#873) #874

Merged
merged 3 commits into from Jan 28, 2020
Merged

fix: move the scroll position on calling focus, focusAtAPI(#873) #874

merged 3 commits into from Jan 28, 2020

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Jan 20, 2020

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

@js87zz js87zz changed the title fix: move the scroll position on calling focus, focusAtAPI fix: move the scroll position on calling focus, focusAtAPI(#873) Jan 20, 2020
dongwoo-kim
dongwoo-kim approved these changes Jan 20, 2020
View reviewed changes
Copy link

@dongwoo-kim dongwoo-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν…ŒμŠ€νŠΈ μ½”λ“œκ°€ 점점 κΉ”λ”ν•΄μ§€λ„€μš” γ…Žγ…Ž μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!

jung-han
jung-han approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

@js87zz js87zz merged commit a716dbc into master Jan 28, 2020
@js87zz js87zz deleted the fix/focus-scroll-position branch January 28, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwoo-kim dongwoo-kim dongwoo-kim approved these changes

@jung-han jung-han jung-han approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@js87zz @dongwoo-kim @jung-han