Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work when running undo #315

Closed
4 tasks done
jinwoo-kim-nhn opened this issue Jan 30, 2020 · 0 comments
Closed
4 tasks done

Does not work when running undo #315

jinwoo-kim-nhn opened this issue Jan 30, 2020 · 0 comments
Labels
Bug
Milestone
v3.8.0

Comments

@jinwoo-kim-nhn
Copy link
Contributor

jinwoo-kim-nhn commented Jan 30, 2020 •
edited

Version

3.7.3

Development Environment

Mac, Chrome

Current Behavior

Does not work when running undo action

  • Text Menu
  • Shape Menu
  • Rotate Menu
  • Filter Menu
@jinwoo-kim-nhn jinwoo-kim-nhn added this to the v3.8.0 milestone Jan 30, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn mentioned this issue Jan 30, 2020
Merged
7 tasks
@jinwoo-kim-nhn jinwoo-kim-nhn changed the title Does not work when running undo on text menu. Does not work when running undo Jan 30, 2020
@jinwoo-kim-nhn jinwoo-kim-nhn mentioned this issue Jan 30, 2020
Merged
7 tasks
jinwoo-kim-nhn added a commit that referenced this issue Feb 4, 2020
@jinwoo-kim-nhn
fix: fixed undo redo bug for shape menu (fixed #315 #310) (#316)
d212a4c 
* fix: fixed undo redo bug for shape menu

* apply codereview
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
@jinwoo-kim-nhn @superlucky84 @HerlinMatos
fix: undo slide behavior for text component (fixed nhn#315 nhn#310) (n…
d8ead31 
…hn#314)

* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* fix: added jsdoc for missing jsdoc

* feat: some refactoring for remove event binding

* fix: rotation setAngle undo bug

* feat: improve undo slide behavior for text component - middle commit

* fix: undo redo bug for text menu - prototype commit

* feat: added test for text change undo redo

* middle commit

* feat: apply input ui in range component

* feat: appy value with change input

* feat: some refactoring (change naming, added jsdoc)

* feat: some refactoring for remove event binding

* feat: improve undo slide behavior for text component - middle commit

* fix: undo redo bug for text menu - prototype commit

* feat: added test for text change undo redo

* fix: incorrected rebase line delete

* fix: unnessary text style property (textDecoration)

* fixed: some refactoring

* fix: fixed incorrected text option

* fix: apply codereview

Co-authored-by: superlucky84 <superlucky84@gmail.com>
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
@jinwoo-kim-nhn @HerlinMatos
fix: fixed undo redo bug for shape menu (fixed nhn#315 nhn#310) (nhn#316
961abdb 
)

* fix: fixed undo redo bug for shape menu

* apply codereview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v3.8.0
Development

No branches or pull requests
1 participant
@jinwoo-kim-nhn