Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is installing file-saver needed to enable download button? #318

Closed
ryuckel opened this issue Feb 2, 2020 · 3 comments
Closed

Is installing file-saver needed to enable download button? #318

ryuckel opened this issue Feb 2, 2020 · 3 comments
Labels
Enhancement Enhance performance or improve usability of original features. Question

Comments

@ryuckel
Copy link
Contributor

ryuckel commented Feb 2, 2020

Version

tui-image-editor@3.3.1

Development Environment

macOS/chrome/vue.js 2.5.10

Current Behavior

when i click Download Button, image displays other tab.
After added file-saver by npm install command and import this module to component using tui-image-editor,
I can download image to local as I expected.

Is it correct way to enable download feature?
If my understanding is not right, please give me a procedure of import file-saver
@jinwoo-kim-nhn
Copy link
Contributor

hi @ryuckel
I'm sorry that this part is not documented.
Need to improve in a more general way. But before that like below:

To download as a file, you can use [fileSaver] (https://www.npmjs.com/package/file-saver/v/1.3.2) together or implement window.saveAs.

@jinwoo-kim-nhn jinwoo-kim-nhn added Question Enhancement Enhance performance or improve usability of original features. labels Feb 7, 2020
@ryuckel
Copy link
Contributor Author

ryuckel commented Feb 7, 2020

@jinwoo-kim-nhn
Thank you for your reply.
I got it. And I will make PR about this.

@jinwoo-kim-nhn
Copy link
Contributor

jinwoo-kim-nhn commented Feb 7, 2020 •
edited
Loading

@ryuckel thanks. good. i like you

@ryuckel ryuckel mentioned this issue Feb 7, 2020
Closed
@jinwoo-kim-nhn jinwoo-kim-nhn mentioned this issue Feb 7, 2020
Closed
ryuckel added a commit to ryuckel/tui.image-editor that referenced this issue Feb 7, 2020
@ryuckel
fix:nhn#318
d206ac1
jinwoo-kim-nhn pushed a commit that referenced this issue Feb 12, 2020
@ryuckel
fix:#318 (#326)
9d366bf
@jinwoo-kim-nhn jinwoo-kim-nhn mentioned this issue Feb 13, 2020
Open
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this issue Jul 2, 2020
@ryuckel @HerlinMatos
fix:nhn#318 (nhn#326)
9ae85ce
@lja1018 lja1018 closed this as completed Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Enhance performance or improve usability of original features. Question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lja1018 @jinwoo-kim-nhn @ryuckel