Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text align button block need prefixed for active class names #589

Closed
seytar opened this issue May 2, 2021 · 2 comments
Closed

Text align button block need prefixed for active class names #589

seytar opened this issue May 2, 2021 · 2 comments
Labels
Bug

Comments

@seytar
Copy link
Contributor

seytar commented May 2, 2021 •
edited
Loading

Describe the bug
Active class names are generic: left, center, right. Possibly conflict with css from outside.

Screenshots
Screenshot from 2021-05-02 08-54-28
Screenshot from 2021-05-02 08-54-38
@seytar seytar added the Bug label May 2, 2021
@seytar seytar changed the title Text align button block need prefixed for active class name Text align button block need prefixed for active class names May 2, 2021
@lja1018
Copy link
Contributor

lja1018 commented May 12, 2021

@seytar
I'm sorry for the late reply. We will review the PR ASAP.

lja1018 pushed a commit that referenced this issue May 26, 2021
@seytar
fix: Isolated text align button active class names #589 (#590)
f841d49 
* adding resize functionality

* add resize icon

* UI minor style improvements

* Image resizing functionality implemented

* fix sometimes image cropped on resizing bug.

* fix image resizing undo and redo functions problems

* Beautified resize label in history list

* Added image resizing icon on history

* changes documentation commentline resize component and command files. Removed unnecesary css style: .{prefix}-submenu-align-mr-0

* Created resize API for graphics.

* simplifying resize methods

* simplifying resize methods

* deleted unnecessary comments

* simplified selectionCleared method

* fix test: 'switches drawing modes'

* fix dimension update after scaling bug

* lockState is turned on recalculated max width and heigth values

* remove unnecessary lockState property and set method

* added resize component test case

* Resize command tests added.

* import Promise from tui image editor utils for old browser support

* Simplified ui limit set functions.

* Simple language change on resize tests: should setted original -> should set original

* Resize added to Features title on README.md

* Add prefix text align block's active class: tie-text-align-

Co-authored-by: Saadettin Sivaz <saadettin.sivaz@turkai.com>
@lja1018
Copy link
Contributor

lja1018 commented Oct 22, 2021

This issue has been solved.

@lja1018 lja1018 closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seytar @lja1018