Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change the brightness through api method. #616

Closed
yugo-ibuki opened this issue Aug 4, 2021 · 3 comments · Fixed by #687
Closed

How to change the brightness through api method. #616

yugo-ibuki opened this issue Aug 4, 2021 · 3 comments · Fixed by #687
Labels

Comments

@yugo-ibuki
Copy link

Hi, I have a question about index.d.ts.
I tried to change the brightness for the image through applyFilter() method
like as bellow:

imageEditor.applyFilter('brightness', {'brightness': parseInt(value, 10) / 255})

but ts compiler says
TS2345: Argument of type '{ brightness: number; }' is not assignable to parameter of type '{ maskObjId: number; }'.

I just commented out maskObjId: number; in index.d.ts, then it works fine.
I know it's not good idea in the way.

so, my question is
Is there any way to change the brightness other than commenting out the object content?

Thanks in advance.

@lja1018
Copy link
Contributor

lja1018 commented Aug 11, 2021

@yugo-ibuki
Sorry for the late reply.
The index.d file seems to be missing a type.
I'll fix it.

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Sep 21, 2021
@stale
Copy link

stale bot commented Oct 12, 2021

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this as completed Oct 12, 2021
@lja1018 lja1018 reopened this Oct 22, 2021
@stale stale bot removed the inactive label Oct 22, 2021
@lja1018 lja1018 added Bug and removed Question labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants