Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve applyFilter type (fix #616) #687

Merged
merged 1 commit into from
Dec 20, 2021
Merged

refactor: improve applyFilter type (fix #616) #687

merged 1 commit into from
Dec 20, 2021

Conversation

lja1018
Copy link
Contributor

@lja1018 lja1018 commented Dec 17, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@lja1018 lja1018 changed the title refactor: improve applyFilter type (resolve #616) refactor: improve applyFilter type (fix #616) Dec 17, 2021
adhrinae
adhrinae approved these changes Dec 20, 2021
View reviewed changes
Copy link

@adhrinae adhrinae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

jwlee1108
jwlee1108 approved these changes Dec 20, 2021
View reviewed changes
Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰완료합니다.

@lja1018 lja1018 merged commit 2ffbbb6 into master Dec 20, 2021
@lja1018 lja1018 deleted the refactor/improve-types branch December 20, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhrinae adhrinae adhrinae approved these changes

@jwlee1108 jwlee1108 jwlee1108 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to change the brightness through api method.
3 participants
@lja1018 @adhrinae @jwlee1108