fix: always reset time when setting range #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lja1018
reviewed
Aug 11, 2021
src/js/timepicker/index.js
Outdated
| @@ -768,7 +768,9 @@ var TimePicker = defineClass( | |||
| * @private | |||
| */ | |||
| applyRange: function(beginHour, beginMin, endHour) { | |||
| this.setTime(beginHour, beginMin); | |||
| if (this.isLaterThanSettedTime(beginHour, beginMin)) { | |||
There was a problem hiding this comment.
setted가 없는 단어라 isLaterThanSetTime이면 될 것 같아요.
jwlee1108
reviewed
Aug 11, 2021
src/js/timepicker/index.js
Outdated
| @@ -836,6 +838,17 @@ var TimePicker = defineClass( | |||
| minute <= END_NUMBER_OF_MINUTE; | |||
| }, | |||
|
|
|||
| /** | |||
| * Compare given time with setted time | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Fix an issue where when setting a range, the time would be reset to the start time of the range regardless of the set time
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨