Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting folders in post directories #5

Closed
wants to merge 1 commit into from
Closed

supporting folders in post directories #5

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2016

Not only post-files, but also post-directories could be supported with this plugin. Fixing issue #4

Not only files, but also directories could be supported with this plugin. Fixing issue [#4](#4)
@nhoizey
Copy link
Owner

nhoizey commented Jan 16, 2017

Can you explain?

Directories are created if there are files in them we need to copy, AFAIK.

And in fact, current version of the plugin already copies the subfolder and the file in it, or is it Jekyll in last versions?

@ghost
Copy link
Author

ghost commented Jan 16, 2017

Lets say we have a post and beside it, there is an image folder called images in which contains all images related to that post.
The post url would be example.com/myPost/ and the images are image1.jpg, image2.jpg, etc
when using this plugin, the url of the images would be like example.com/myPost/image1.jpg
but I wanted something like example.com/myPost/images/image1.jpg. So I created this pull request.

@nhoizey
Copy link
Owner

nhoizey commented Jan 16, 2017

On my simple test Jekyll installation, the plugin already does what you need, without the pull request.

Well, not exactly, the image is put twice in the destination: one in the post HTML folder, and one in the subfolder.

image

So I'm not sure your PR is needed, but there's a little issue of duplication.

@ghost
Copy link
Author

ghost commented Jan 16, 2017

Whats your jekyll version? I'm using 3.2

@nhoizey
Copy link
Owner

nhoizey commented Jan 16, 2017

I use Jekyll 3.2.1

@nhoizey
Copy link
Owner

nhoizey commented Jan 16, 2017

Same thing with Jekyll 3.3.1

@nhoizey
Copy link
Owner

nhoizey commented Jan 17, 2017

@hnaseri89 sorry, I've pushed some code I wrote earlier, so your PR now has conflict.

I will dive into this sub-folders need and look at your code.

@nhoizey
Copy link
Owner

nhoizey commented May 31, 2018

Should be good with v3.0.0

@nhoizey nhoizey closed this May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants