Add linux support #4
Conversation
Duncaen
force-pushed
the
master
branch
3 times, most recently
from
a70c699
to
23f3891
Compare
configure
Outdated
| int main(void) { | ||
| const char s1[] = "foo"; | ||
| char s2[10]; | ||
| strlccat(s2, s1, sizeof(s2)); |
|
Duncaen, thanks for your interest, and more thanks for your patch. Unfortunately, I am traveling for ~6 months and have no access to a computer to test this (or to run git). If you're interested, I'd be happy to make you a maintainer of this repository? |
|
Hi @nholstein, thanks for you response, I'm interested in maintaining this repository, but I don't have a Mac OS system to test my patches. @frgm thanks for pointing out the typos. I'm not sure yet how to properly handle pam sessions, to do it correctly i would have to fork and close the session after the child terminates. I plan to add a patch for resetting rlimits too, but have to investigate which resources need to be set on other systems than Linux. |
|
OK, @Duncaen & @frgm. I think all I can do with the mobile interface is to merge pull requests. @Duncaen, would you mind creating a separate pull request adding a paragraph to the top of the README with a note that this repo/OSX support is temporarily unmaintained, and a link to your repo for Linux support? I can then merge that. Sound good? |
|
Per the above comment, I've merged in request #5 biting that this repository is currently unmaintained. I'll look into merging this when I return. @Duncaen, a huge "danke" for your help in this. I'll have limited access to email over the next few months; if you have any questions I'll help as best as possible. Cheers! |
|
@nholstein thank you too for starting this, have a nice and save travel. |
* add usage() function * remove unused options * stop parsing option(s) if unknown was found * set up "--enable-debug" and "--enable-static" options Closes: #1 [via git-merge-pr]
man{1,5} is not expanded
set default DESTDIR to an empty string
`mkdir -p //usr/bin` - it creates dir, but looks not very nice
also remove "[settings]" from configure usage
fix make install
The doas style prompt "doas ($USER@$HOST) password:" is used if pam gives back a prompt that matches "Password:[ ]" in other cases the prompt provided by pam is used.
Both work fine, PAM_REINITIALIZE_CRED is the more correct choice and is required on Solaris, see sudo bug #642; https://bugzilla.sudo.ws/show_bug.cgi?id=642
we don't keep writing past the end. (the perils of trying to recover from parse errors.) noticed by Jan Schreiber
This is a fixup for commit 01c658f where the behaviour was changed to not inherit the PATH variable by default.
…option in doas.conf instead of a generic "would prompt for password", which could lead people into believing that persist could work with this option. OK tedu@ Feedback and OK kn@
OK kn@ tedu@
…reallocarray(3) will fail if nmemb * size would overflow. OK tb@ martijn@
… that happening and print a message.
pam configuration files are not portable, its the job of the package maintainer or user who builds opendoas themselves to configure pam in a safe and usable way.
Closes: #54 [via git-merge-pr]
No description provided.