Skip to content

Commit

Permalink
Fix setting of permissive- (#224)
Browse files Browse the repository at this point in the history
The current `CMakeLists.txt` adds `"/permissive-"` as a `target_compile_definitions`. However it is a flag not a compile definition, see here https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=vs-2017

Co-authored-by: Nic Holthaus <nholthaus@gmail.com>
  • Loading branch information
cstratopoulos and nholthaus committed Oct 7, 2020
1 parent dcc2f89 commit 0cab85a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ target_include_directories(${PROJECT_NAME}
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
# enable parallel build
set( ENV{CL} /MP )
target_compile_options(${PROJECT_NAME} INTERFACE "/permissive-")
target_compile_options(${PROJECT_NAME} INTERFACE /permissive-)
elseif("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
# Increase warning levels
add_compile_options(-Wall -Wextra -pedantic)
Expand Down

0 comments on commit 0cab85a

Please sign in to comment.