Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reader/writer allocations #116

Closed
nhooyr opened this issue Aug 20, 2019 · 1 comment
Closed

Reduce reader/writer allocations #116

nhooyr opened this issue Aug 20, 2019 · 1 comment

Comments

@nhooyr
Copy link
Owner

nhooyr commented Aug 20, 2019

Can just compare the pointers.

gorilla/websocket#535 (comment)

@nhooyr nhooyr added the perf label Aug 20, 2019
nhooyr added a commit that referenced this issue Aug 20, 2019
@nhooyr
Copy link
Owner Author

nhooyr commented Aug 21, 2019

Should detect concurrent reads and then reduce reader alloc.

@nhooyr nhooyr closed this as completed in 63f27e2 Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant