Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone options #259

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Clone options #259

merged 1 commit into from
Sep 24, 2020

Conversation

abursavich
Copy link
Contributor

opts = &*opts is a no-op.

See: https://staticcheck.io/docs/checks#SA4001

@nhooyr
Copy link
Owner

nhooyr commented Sep 24, 2020

Nice catch! Can confirm. I tested it at the time and thought it worked but I guess I got confused.

Copy link
Owner

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @abursavich!

@nhooyr nhooyr merged commit fdc4079 into nhooyr:dev Sep 24, 2020
@icholy
Copy link

icholy commented Oct 1, 2020

There are still 2 more instances of this.

$ git grep "\&\*
dial.go:        copts = &*copts
internal/test/wstest/pipe.go:   dialOpts = &*dialOpts

@nhooyr
Copy link
Owner

nhooyr commented Oct 2, 2020

Good eye @icholy, I've made note of those in my TODO and will have a PR up to fix shortly.

nhooyr added a commit that referenced this pull request Jan 9, 2021
Thank you @icholy for identifying these in #259 (comment)
nhooyr added a commit that referenced this pull request Jan 9, 2021
Thank you @icholy for identifying these in
#259 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants