Data race on Conn.closeErr

[haha454]

When I run my go program with race detector enabled, following logs were observed.

WARNING: DATA RACE
local-setup-websocket-api-1  | Write at 0x00c0002e31b0 by goroutine 129:
local-setup-websocket-api-1  |   nhooyr.io/websocket.(*Conn).setCloseErrLocked()
local-setup-websocket-api-1  |       /go/pkg/mod/nhooyr.io/websocket@v1.8.10/close.go:288 +0xd0
local-setup-websocket-api-1  |   nhooyr.io/websocket.(*Conn).setCloseErr()
local-setup-websocket-api-1  |       /go/pkg/mod/nhooyr.io/websocket@v1.8.10/close.go:282 +0x4c
local-setup-websocket-api-1  |   nhooyr.io/websocket.(*Conn).timeoutLoop()
local-setup-websocket-api-1  |       /go/pkg/mod/nhooyr.io/websocket@v1.8.10/conn.go:190 +0x224
local-setup-websocket-api-1  |   nhooyr.io/websocket.newConn.func2()
local-setup-websocket-api-1  |       /go/pkg/mod/nhooyr.io/websocket@v1.8.10/conn.go:137 +0x80
local-setup-websocket-api-1  |
local-setup-websocket-api-1  | Previous read at 0x00c0002e31b0 by goroutine 165:
local-setup-websocket-api-1  |   nhooyr.io/websocket.(*Conn).CloseNow()
local-setup-websocket-api-1  |       /go/pkg/mod/nhooyr.io/websocket@v1.8.10/close.go:117 +0x138
...
...

Apparently it's because when it's being set, it's protected by c.closeMu.

websocket/close.go

Line 288 in e3a2d32

c.closeErr = fmt.Errorf("WebSocket closed: %w", err)

However it's not when it's being read.

websocket/close.go

Line 117 in e3a2d32

return c.closeErr

[haha454]

I realise there is a PR #427 for it.

[nhooyr]

Thanks for reporting. I've fixed this in #427. Please review and let me know if you see anything else.

[nhooyr]

Sorry for the delay. Fixed by #427.