Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Conn.SetReadLimit(n int64) #83

Closed
nhooyr opened this issue May 30, 2019 · 1 comment
Closed

Add Conn.SetReadLimit(n int64) #83

nhooyr opened this issue May 30, 2019 · 1 comment
Labels
enhancement

Comments

@nhooyr
Copy link
Owner

nhooyr commented May 30, 2019

The read limit for the wspb/wsjson sub packages should be configurable.

The default read limit should be 32 KB.
@nhooyr nhooyr changed the title Add SetReadLimit(n int64) Add Conn.SetReadLimit(n int64) May 30, 2019
nhooyr added a commit that referenced this issue May 30, 2019
@nhooyr
Expand API
36d5ce8 
- Closes #1 (Ping API)
- Closes #75 (Read/Write convienence methods)
- Closes #83 (SetReadLimit)
nhooyr added a commit that referenced this issue May 30, 2019
@nhooyr
Expand API
6ad088f 
- Closes #1 (Ping API)
- Closes #62 (Read/Write convienence methods)
- Closes #83 (SetReadLimit)
nhooyr added a commit that referenced this issue May 30, 2019
@nhooyr
Expand API
98bf7a1 
- Closes #1 (Ping API)
- Closes #62 (Read/Write convienence methods)
- Closes #83 (SetReadLimit)
@nhooyr
Copy link
Owner Author

nhooyr commented May 31, 2019

Should also not use ioutil.LimitReader and instead throw a real error, not a EOF.

@nhooyr nhooyr closed this as completed in 4de9061 May 31, 2019
@ioogle ioogle mentioned this issue Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhooyr