Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Ruby 2.1.1 supported by omniauth-apple ? #61

Closed
dduwoye opened this issue Oct 19, 2020 · 3 comments
Closed

Is Ruby 2.1.1 supported by omniauth-apple ? #61

dduwoye opened this issue Oct 19, 2020 · 3 comments

Comments

@dduwoye
Copy link

dduwoye commented Oct 19, 2020

Hello,

It seems there is a problem with the gem and my config. The app I'm working with is build with Ruby 2.1.1 and Rails 3.2.19 and the following syntax of the apple.rb lib is raising errors:

/Users/denis/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/activesupport-3.2.19/lib/active_support/dependencies.rb:251:in `require': /Users/denis/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/omniauth-apple-1.0.0/lib/omniauth/strategies/apple.rb:33: syntax error, unexpected '.' (SyntaxError)
...s['id_token'] || access_token&.params&.dig('id_token')
...                               ^
/Users/denis/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/omniauth-apple-1.0.0/lib/omniauth/strategies/apple.rb:60: syntax error, unexpected '.'
...id_info ||= if request.params&.key?('id_token') || access_to...
...                               ^
/Users/denis/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/gems/omniauth-apple-1.0.0/lib/omniauth/strategies/apple.rb:60: syntax error, unexpected '.'
...?('id_token') || access_token&.params&.key?('id_token')

Thanks for your help.

@dduwoye dduwoye changed the title /lib/omniauth/strategies/apple.rb:33: syntax error, unexpected '.' Is Ruby 2.1.1 supported by omniauth-apple ? Oct 19, 2020
@btalbot
Copy link
Contributor

btalbot commented Oct 19, 2020

As any support for ruby 2.1 ended in 2017, I would guess that the answer is "no", it is not supported.
https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/

As this is a security critical feature, I urge you to update the a current and supported version.

@rsespinosa
Copy link

You need to use ruby 2.3.0 and above because it requires secure navigation operators (e.g. params&)

@nov
Copy link
Collaborator

nov commented Sep 27, 2022

use active versions

@nov nov closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants