Use JWT gem and some refactor

[fjaeger]

The jwt gem is way more mature and more widely used than json-jwt.

[fjaeger]

What do you think (besides the 😄)?

[merefield]

This PR appears to solve the issue with the lack of name and email? (which is critical to adoption for us)

[fjaeger]

This PR appears to solve the issue with the lack of name and email?

No, unfortunately not. Apple needs to provide a REST API endpoint to retrieve name/email as they currently only pass this information upon successful authentication once and not on subsequent authentications.

→ It's on Apple now to get their homework done

[merefield]

as they currently only pass this information upon successful authentication once and not on subsequent authentications

Let me check, I think that's probably good enough for our use case (Authentication and account setup in Discourse).

[fjaeger]

as they currently only pass this information upon successful authentication once and not on subsequent authentications

Let me check, I think that's probably good enough for our use case (Authentication and account setup in Discourse).

Could be, but imagine the following: User signs up via Apple, then deletes the account. Next time during "Sign in with Apple", the authentication would be successful, but would not include email/name anymore as it was provided on first auth

[dzunk]

Derp, of course there's already a PR open... fixes #10.

[fjaeger]

By the way, this PR also handles #9

[dzunk]

@nhosoya with iOS 13 and the "Sign in with Apple" requirement coming soon, it's important that we get the omniauth integration working well. My team at work is focused on this right now, and it would be very valuable to have an up-to-date version of this gem on Rubygems. Do you think you'll have time to take a look at this and merge the PR soon, or possibly allow another maintainer to take over?

[nhosoya]

@fjaeger @dzunk
Thank you for your great contributions, and sorry for the delay...

[nhosoya]

LGTM!