fix: Provide protocol header expected by browser #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hasura sends back a header indicating which line protocol is going to be used. In browsers, if a matching header is not sent on the request, the browser will reject the handshake. This differs from the behavior in Dart's native websocket, which does not perform this validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hasura sends back a header upon connection indicating which line protocol is going to be used for the rest of the socket session. In browsers, if a matching header is included with the connection request, the browser will reject the handshake.
This differs from the behavior in Dart's native websocket, which does not perform this validation.
Fixes #15