[refs #168] use the correct footer links in examples and docs

nhsuk · Jun 21, 2019 · ef1a9d9 · ef1a9d9
1 parent 383d4f3
commit ef1a9d9
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 41 deletions.
diff --git a/app/components/all.njk b/app/components/all.njk
@@ -662,7 +662,7 @@
   {{ footer({
     "links": [
       {
-        "URL": "https://www.nhs.uk/Pages/nhs-sites.aspx",
+        "URL": "https://www.nhs.uk/nhs-sites",
         "label": "NHS sites"
       },
       {

diff --git a/app/components/footer/columns.njk b/app/components/footer/columns.njk
@@ -9,36 +9,36 @@
     "list": "nhsuk-footer__list--three-columns",
     "links": [
       {
-        "URL": "#",
+        "URL": "https://www.nhs.uk/nhs-sites/",
         "label": "NHS sites"
       },
       {
-        "URL": "#",
+        "URL": "https://www.nhs.uk/about-us/",
         "label": "About us"
       },
       {
-        "URL": "#",
+        "URL": "https://www.nhs.uk/contact-us/",
         "label": "Contact us"
       },
       {
-        "URL": "#",
+        "URL": "https://www.nhs.uk/personalisation/login.aspx",
+        "label": "Profile editor login"
+      },
+      {
+        "URL": "https://www.nhs.uk/about-us/sitemap/",
         "label": "Sitemap"
       },
       {
-        "URL": "#",
+        "URL": "https://www.nhs.uk/accessibility/",
         "label": "Accessibility"
       },
       {
-        "URL": "#",
+        "URL": "https://www.nhs.uk/our-policies/",
         "label": "Our policies"
       },
       {
-        "URL": "#",
+        "URL": "https://www.nhs.uk/our-policies/cookies-policy/",
         "label": "Cookies"
-      },
-      {
-        "URL": "#",
-        "label": "Profile editor login"
       }
     ]
   })}}

diff --git a/app/components/footer/index.njk b/app/components/footer/index.njk
@@ -8,7 +8,7 @@
   {{ footer({
     "links": [
       {
-        "URL": "https://www.nhs.uk/Pages/nhs-sites.aspx",
+        "URL": "https://www.nhs.uk/nhs-sites",
         "label": "NHS sites"
       },
       {

diff --git a/docs/installation/installing-compiled.md b/docs/installation/installing-compiled.md
@@ -221,8 +221,8 @@ If you require any of this functionality, you should [install using npm](/docs/i
         <div class="nhsuk-width-container">
           <h2 class="nhsuk-u-visually-hidden">Support links</h2>
           <ul class="nhsuk-footer__list">
-            <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/Pages/nhs-sites.aspx">NHS sites</a></li>
-            <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us">About us</a></li>
+            <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/nhs-sites/">NHS sites</a></li>
+            <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us/">About us</a></li>
             <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/contact-us/">Contact us</a></li>
             <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us/sitemap/">Sitemap</a></li>
             <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/our-policies/">Our policies</a></li>

diff --git a/packages/components/footer/README.md b/packages/components/footer/README.md
@@ -19,8 +19,8 @@ Find out more about the footer component and when to use it in the [NHS digital
     <div class="nhsuk-width-container">
       <h2 class="nhsuk-u-visually-hidden">Support links</h2>
       <ul class="nhsuk-footer__list">
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/Pages/nhs-sites.aspx">NHS sites</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us">About us</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/nhs-sites/">NHS sites</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us/">About us</a></li>
         <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/contact-us/">Contact us</a></li>
         <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us/sitemap/">Sitemap</a></li>
         <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/our-policies/">Our policies</a></li>
@@ -39,11 +39,11 @@ Find out more about the footer component and when to use it in the [NHS digital
 {{ footer({
   "links": [
     {
-      "URL": "https://www.nhs.uk/Pages/nhs-sites.aspx",
+      "URL": "https://www.nhs.uk/nhs-sites/",
       "label": "NHS sites"
     },
     {
-      "URL": "https://www.nhs.uk/about-us",
+      "URL": "https://www.nhs.uk/about-us/",
       "label": "About us"
     },
     {
@@ -73,17 +73,17 @@ Find out more about the footer component and when to use it in the [NHS digital
   <div class="nhsuk-footer" id="nhsuk-footer">
     <div class="nhsuk-width-container">
       <h2 class="nhsuk-u-visually-hidden">Support links</h2>
-      <ul class="nhsuk-footer__list nhsuk-footer__list--three-columns ">
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">NHS sites</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">About us</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">Contact us</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">Sitemap</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">Accessibility</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">Our policies</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">Cookies</a></li>
-        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="#">Profile editor login</a></li>
+      <ul class="nhsuk-footer__list nhsuk-footer__list--three-columns">
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/nhs-sites/">NHS sites</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us/">About us</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/contact-us/">Contact us</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/personalisation/login.aspx">Profile editor login</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/about-us/sitemap/">Sitemap</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/accessibility/">Accessibility</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/our-policies/">Our policies</a></li>
+        <li class="nhsuk-footer__list-item"><a class="nhsuk-footer__list-item-link" href="https://www.nhs.uk/our-policies/cookies-policy/">Cookies</a></li>
       </ul>
-      <p class="nhsuk-footer__copyright">&copy; Crown copyright</p>
+      <p class="nhsuk-footer__copyright">© Crown copyright</p>
     </div>
   </div>
 </footer>
@@ -96,36 +96,36 @@ Find out more about the footer component and when to use it in the [NHS digital
   "list": "nhsuk-footer__list--three-columns",
   "links": [
     {
-      "URL": "#",
+      "URL": "https://www.nhs.uk/nhs-sites/",
       "label": "NHS sites"
     },
     {
-      "URL": "#",
+      "URL": "https://www.nhs.uk/about-us/",
       "label": "About us"
     },
     {
-      "URL": "#",
+      "URL": "https://www.nhs.uk/contact-us/",
       "label": "Contact us"
     },
     {
-      "URL": "#",
+      "URL": "https://www.nhs.uk/personalisation/login.aspx",
+      "label": "Profile editor login"
+    },
+    {
+      "URL": "https://www.nhs.uk/about-us/sitemap/",
       "label": "Sitemap"
     },
     {
-      "URL": "#",
+      "URL": "https://www.nhs.uk/accessibility/",
       "label": "Accessibility"
     },
     {
-      "URL": "#",
+      "URL": "https://www.nhs.uk/our-policies/",
       "label": "Our policies"
     },
     {
-      "URL": "#",
+      "URL": "https://www.nhs.uk/our-policies/cookies-policy/",
       "label": "Cookies"
-    },
-    {
-      "URL": "#",
-      "label": "Profile editor login"
     }
   ]
 })}}
@@ -140,7 +140,7 @@ The footer Nunjucks macro takes the following arguments:
 | **links**             | array    | No        | Array of primary navigation items for use in the footer. |
 | **links.[].url**      | string   | No        | The href of a primary navigation item in the footer. |
 | **links.[].label**    | string   | No        | The label of a primary navigation item in the footer. |
-| **list**              | string   | No        | Option for the links list to be in columns eg. `nhsuk-footer__list--three-columns` |
+| **list**              | string   | No        | Option for the links list to be in columns to support more links. |
 | **classes**           | string   | No        | Optional additional classes to add to the footer container. Separate each class with a space. |
 | **attributes**        | object   | No        | Any extra HTML attributes (for example data attributes) to add to the footer container. |