Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the ITCSS structure to our project #38

Closed
chrimesdev opened this issue Oct 1, 2018 · 0 comments
Closed

Implement the ITCSS structure to our project #38

chrimesdev opened this issue Oct 1, 2018 · 0 comments

Comments

@chrimesdev
Copy link
Contributor

Implement ITCSS (Inverted Triangle CSS) structure to our project to help reduce specificity and increase maintainability. See the following article about ITCSS https://csswizardry.net/talks/2014/11/itcss-dafed.pdf

Have a look into Parker for plotting our specificity, so that we can track it over time. See the following articles about specificity https://csswizardry.com/2014/10/the-specificity-graph/ & https://csswizardry.com/2014/07/hacks-for-dealing-with-specificity/ & https://cssguidelin.es/#specificity
chrimesdev added a commit that referenced this issue Oct 2, 2018
@chrimesdev
[refs #38] Start of ITCSS structure
157fb81 
Refactor the generic; tools and settings layer of the ITCSS structure.
Start of work on the overall restructure.
chrimesdev added a commit that referenced this issue Oct 2, 2018
@chrimesdev
[refs #38] Missing utilities and ITCSS
bbd8c7d 
Add missing utilities files and further improvements to the ITCSS
structure.
chrimesdev added a commit that referenced this issue Oct 2, 2018
@chrimesdev
[refs #38] Further ITCSS structure improvements
7ac67eb 
Reorganising some of the files into folders and renaming them
to be more accurate of the task they perform. Also cleaned up some
of the comment templates, ready to be filled in during refactoring.
chrimesdev added a commit that referenced this issue Oct 3, 2018
@chrimesdev
[refs #38] Seperate elements and classes
674553e 
Seperate the elements styling from the class name styling,
introducing a new folder called styles to hold all our classes for
core components.
chrimesdev added a commit that referenced this issue Oct 3, 2018
@chrimesdev
[refs #38] Seperate elements and classes
67e7b1a 
Seperate the elements styling from the class name styling,
introducing a new folder called styles to hold all our classes for
core components.
chrimesdev added a commit that referenced this issue Oct 3, 2018
@chrimesdev
[refs #38] Separate elements and classes
8d513e5 
Separate the elements styling from the class name styling,
introducing a new folder called styles to hold all our classes for
core components.
davidhunter08 added a commit that referenced this issue Oct 3, 2018
@davidhunter08
[refs #38] Refactoring code to improve specificity
c943e33 
We have used the specificty css graph to help improve the code structure.
davidhunter08 added a commit that referenced this issue Oct 4, 2018
@davidhunter08
[refs #38] Updated files in styles with comments
4c704d8 
All Sass files in styles now have comments formatted in the ITCSS way.
davidhunter08 added a commit that referenced this issue Oct 5, 2018
@davidhunter08
[refs #38] Refactored files with comments
5306782 
Refactored files within tools, elements and styles, adding comments
to clearly state what the file is and what it does.
davidhunter08 added a commit that referenced this issue Oct 8, 2018
@davidhunter08
[refs #38] Updated comments in Sass files
9f08d81 
Added comments to Sass files using the set format.
Files included:
/core/generic/_box-sizing.scss
/core/settings/_spacing.scss
/core/tools/_functions.scss
/core/tools/_typography.scss
davidhunter08 added a commit that referenced this issue Oct 8, 2018
@davidhunter08
[refs #38] Updated main-wrapper in objects
c0e09b2 
I changes the main-wrapper spacing nhsuk-responsive-padding(6) to (7).
This creates equal spacing above and below the page heading <h1>.
Doing this meant the mixin for main-wrapper--l was not needed so it
was deleted.
davidhunter08 added a commit that referenced this issue Oct 9, 2018
@davidhunter08
[refs #38] Added comments to tools/_ifff
20a4624
chrimesdev added a commit that referenced this issue Oct 9, 2018
@chrimesdev
Merge pull request #68 from nhsuk/refactor/specificity-itcss
a74c757 
[refs #38] ITCSS structure work
@chrimesdev chrimesdev mentioned this issue Oct 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrimesdev