Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Date #65

Closed
16 tasks done
davidhunter08 opened this issue Oct 2, 2018 · 0 comments
Closed
16 tasks done

Review Date #65

davidhunter08 opened this issue Oct 2, 2018 · 0 comments
Assignees
@chrimesdev
Projects
nhsuk-frontend-prerelease-backlog

Comments

@davidhunter08
Copy link
Contributor

davidhunter08 commented Oct 2, 2018 •
edited
Loading

Use this issue to refactor the component: Review Date

Refactor checklist

  • Sass file contains comments, using the comments template format
  • Refactor code using BEM for naming
  • Remove / refactor any code smells
  • Remove / refactor any 'random numbers' or make comments where it is necessary to use

Component checklist

  • SCSS
  • SCSS lint
  • HTML template
  • HTML validate & lint
  • Nunjucks macro
  • A standalone example
  • README/Documentation
  • Pseudocode tests
  • Visual tests
  • Tested against our testing policy (Resolution, Browser & Accessibility)
  • Print stylesheet considered
  • CHANGELOG
@chrimesdev chrimesdev self-assigned this Oct 11, 2018
@chrimesdev chrimesdev moved this from To do to In progress in nhsuk-frontend-prerelease-backlog Oct 11, 2018
chrimesdev added a commit that referenced this issue Oct 11, 2018
@chrimesdev
[refs #65] Review date refactoring and testing
fce2402 
Refactored the review date component to meet the component criteria,
also added examples, documentation and tests for the component.
chrimesdev added a commit that referenced this issue Oct 11, 2018
@chrimesdev
[refs #65] Review date refactoring and testing
817fcee 
Refactored the review date component to meet the component criteria,
also added examples, documentation and tests for the component.
chrimesdev added a commit that referenced this issue Oct 18, 2018
@chrimesdev
[refs #65] Use HTML5 time element for dates
12cf395 
Wrap the last and next review dates in the HTML5 <time> element
for semantics.
chrimesdev added a commit that referenced this issue Oct 19, 2018
@chrimesdev
[refs #65] Change date format
3bb0060 
The review date should be formatted as 1 January 2016, rather than
01/01/2016. This has come from the standards team and there are
benefits to screen readers as they struggle to read out the latter
format.
chrimesdev added a commit that referenced this issue Oct 19, 2018
@chrimesdev
[refs #65] Change date format of review date
da0ef9d 
The review date should be formatted as 1 January 2016, rather than
01/01/2016. This has come from the standards team and there are
benefits to screen readers as they struggle to read out the latter
format.
davidhunter08 added a commit that referenced this issue Oct 22, 2018
@davidhunter08
[refs #65] Review date spacing
c7ff48f 
Changed review date component spacing to
@include nhsuk-responsive-margin(7, 'top');.
This will make the top margin 48px on desktop
and 40px on mobile.
chrimesdev added a commit that referenced this issue Oct 23, 2018
@chrimesdev
[refs #65] Macro double quotes not single
d5e808c 
Use double quotes on nunjucks macros rather than single quotes.
Also delete the CHANGELOG because its not being updated and
should only be used after the first frontend library release.
chrimesdev added a commit that referenced this issue Oct 23, 2018
@chrimesdev
[refs #65] Macro double quotes not single
5fb179a 
Use double quotes on nunjucks macros rather than single quotes.
Also delete the CHANGELOG because its not being updated and
should only be used after the first frontend library release.
chrimesdev added a commit that referenced this issue Oct 23, 2018
@chrimesdev
[refs #65] Macro double quotes not single
05b1f01 
Use double quotes on nunjucks macros rather than single quotes.
Also delete the CHANGELOG because its not being updated and
should only be used after the first frontend library release.
chrimesdev added a commit that referenced this issue Oct 23, 2018
@chrimesdev
[refs #65] Remove time element and scss comments
985f188 
Remove the time element as there is no additional benefit and
we would need to output the date in 2 different formats every time.
Also remove unnecessary css comments.
@davidhunter08 davidhunter08 moved this from In progress to Done in nhsuk-frontend-prerelease-backlog Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrimesdev chrimesdev

Labels
None yet
Projects
No open projects
nhsuk-frontend-prerelease-backlog
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrimesdev @davidhunter08