Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refs #157] Update README for action link and other components #394

Merged
merged 37 commits into from
Feb 27, 2019

Conversation

mcheung-nhs
Copy link
Collaborator

@mcheung-nhs mcheung-nhs commented Feb 19, 2019

Description

Updated READMEs with correct heading structure, updated links to
service manual, and added Nunjucks 'html' warning.

Component READMEs updated:

Checklist

  • SCSS
  • Nunjucks macro
  • A standalone example
  • README/Documentation with HTML snippet
  • Tested against our testing policy (Resolution, Browser & Accessibility)
  • Visual tests (BackstopJS)
  • Print stylesheet considered
  • CHANGELOG entry

@mcheung-nhs mcheung-nhs changed the title [refs #157] [refs #202] [refs #158] [refs #203] [refs #160] [refs #20… [refs #157] Update README for action link and other components Feb 19, 2019
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "nhsuk-frontend",
"version": "1.0.0",
"version": "1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused about this. Isn't this already in master?

@mikemonteith
Copy link
Contributor

mikemonteith commented Feb 25, 2019

I think there's an unnecessary merge in here which means there are 11 duplicated commits in the branch.
Commit 601d2d6

@mcheung-nhs mcheung-nhs merged commit 4f97462 into master Feb 27, 2019
@mcheung-nhs mcheung-nhs deleted the docs/readmes branch February 27, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants