Update page template examples #1975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
previously approved these changes
Jun 5, 2024
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
Co-authored-by: Frankie Roberto <frankie@frankieroberto.com>
frankieroberto
previously approved these changes
Jun 6, 2024
sarawilcox
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Hi @anandamaryon1, I've made a suggestion for the text re the larger h1 on content pages.
I couldn't work out how to suggest a change to the wording under Transactional pages that says: "We also recommended you use a smaller page heading size using the .nhsuk-heading-l modifier class."
Please could we change it to "We also recommend you use a smaller h1 heading size using the .nhsuk-heading-lmodifier class."
Co-authored-by: Sara Wilcox <45792959+sarawilcox@users.noreply.github.com>
|
@sarawilcox I've made your suggested change. |
|
Release at same time as: #1974 |
anandamaryon1
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1974, this makes a few updates to the page template examples:
nhsuk-heading-land put it inside a 2/3 column grid.nhsuk-heading-xlto the content page exampleFixes #1969
Related issue
Checklist
package.json(using SEMVER)