Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add guidance for the main wrapper spacing modifier classes #616

Merged
merged 2 commits into from May 11, 2020
Merged

add guidance for the main wrapper spacing modifier classes #616

merged 2 commits into from May 11, 2020

Conversation

chrimesdev
Copy link
Contributor

@chrimesdev chrimesdev commented May 4, 2020 •
edited by davidhunter08

Description

Add guidance for the <main> wrapper vertical spacing modifier classes

Related issue

(Community backlog Issue 221)

Checklist

@chrimesdev chrimesdev force-pushed the feature/utility-class-layout branch 2 times, most recently from 869c15e to f27eb04 Compare May 4, 2020 15:46
@henocookie
Copy link
Contributor

LGTM 👍 Is it worth adding examples to show how the different spacing of the main wrapper can look?

@davidhunter08
Copy link
Contributor

LGTM

To show an example for:

"We recommend using smaller vertical padding on transactional services."

I'm thinking it might be a good idea to create a question page template in patterns and link to that.

What do you think, @AdamChrimes @henocookie ?

@chrimesdev
Copy link
Contributor Author

Yeah I think have an example on the question page and/or page templates in styles. We can link to that page from here.

@chrimesdev chrimesdev force-pushed the feature/utility-class-layout branch from f27eb04 to cd00395 Compare May 6, 2020 11:39
@chrimesdev chrimesdev marked this pull request as ready for review May 6, 2020 11:43
@davidhunter08 davidhunter08 self-requested a review May 11, 2020 09:50
davidhunter08
davidhunter08 approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@davidhunter08 davidhunter08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @AdamChrimes

@davidhunter08 davidhunter08 merged commit 172fc55 into master May 11, 2020
@davidhunter08 davidhunter08 deleted the feature/utility-class-layout branch May 11, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhunter08 davidhunter08 davidhunter08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrimesdev @henocookie @davidhunter08