Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/christag/ni/debug symbols with release #1040

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

christag-ni
Copy link
Contributor

What does this Pull Request accomplish?

Adds a new asset ni-grpc-device-server-windows-x64-debug-symbols to all releases.

Why should this Pull Request be merged?

This is helpful for debugging release versions .

What testing has been done?

No testing

.github/workflows/build_cmake.yml Outdated Show resolved Hide resolved
@christag-ni christag-ni merged commit 50ee97c into main Feb 14, 2024
10 of 11 checks passed
@christag-ni christag-ni deleted the users/christag/ni/debugSymbolsWithRelease branch February 14, 2024 19:03
@bkeryan
Copy link
Contributor

bkeryan commented Feb 14, 2024

@christag-ni Sorry I didn't notice this before, but in the future, please edit your PR titles so they don't say "Users/..."

@christag-ni
Copy link
Contributor Author

@bkeryan Of course, it must've been a typing error when creating this PR. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants