Bubble up Warnings as Errors #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strainmike
requested review from
reckenro,
astarche and
maxxboehme
as code owners
astarche
approved these changes
Feb 9, 2024
reckenro
approved these changes
Feb 9, 2024
strainmike
changed the title
|
@strainmike Don't have to complete the merge right now, but is there a reason this PR hasn't been completed? Just checking if there's a way I can help. |
I had been waiting for the PR build to complete. It looks like it finally did so I'll complete it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Sets warnings as errors for all source code the project directly owns. Does not affect compiles of codegen'd code or thirdparty code (although pulled in headers can still be problematic). For test code we are additionally ignoring the deprecation of functions like strncpy. This change does not enable any additional warnings, but that can come later.
The vast majority of the code changes are casting size types to uint32_t's. There are better fixes for that sort of thing if wanted, I'm open to suggestions.
Why should this Pull Request be merged?
azdo:2507449
I put -Wall -Werror -Wextra on all my projects. Compilers finding bugs for you is great.
What testing has been done?
Built on Windows (with Visual Studio 2022 though) and Linux. I'll see how the PR build goes.