Updated gRPC Device code for all 24C1 RFmx APIs #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
reckenro
reviewed
Mar 13, 2024
reckenro
approved these changes
Mar 13, 2024
astarche
approved these changes
Mar 13, 2024
RahulBenaka
changed the title
maxxboehme
approved these changes
Mar 15, 2024
RahulBenaka
force-pushed
the
users/rnagaraj/specan_24C1_apis
branch
from
0a26868
to
198c9f0
Compare
|
@RahulBenaka @reckenro @astarche I am reruning the windows tests as they appeared to have failed due to some labview crash. |
I see that all the checks have passed successfully. |
maxxboehme
approved these changes
Mar 19, 2024
reckenro
reviewed
Mar 19, 2024
reckenro
reviewed
Mar 19, 2024
reckenro
changed the title
RahulBenaka
added
binary-breaking
|
@astarche Can you please review the PR? I need this PR to be merged before release branch is created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC Supported personalities - BT, LTE, NR, SpecAn and WLAN
What does this Pull Request accomplish?
Updates niRFmxSpecAn in grpc-device-scrapigen to 24.3.0
Updates niRFmxLTE in grpc-device-scrapigen to 24.3.0
Updates niRFmxNR in grpc-device-scrapigen to 24.3.0
Updates niRFmxWLAN in grpc-device-scrapigen to 24.3.0
Updates the gRPC Scrapigen Device Code for SpecAn Marker APIs.
Updates the gRPC Scrapigen Device Code for LTE List Mode APIs, attributes and enums.
Updates the gRPC Scrapigen Device Code for new BT ModSpectrum API and attributes.
Why should this Pull Request be merged?
Updated to match the upcoming release of niRFmxSpecAn 24.3.0
Updated to match the upcoming release of niRFmxLTE 24.3.0
Updated to match the upcoming release of niRFmxNR 24.3.0
Updated to match the upcoming release of niRFmxWLAN 24.3.0
What testing has been done?
Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxspecan/export/ to grpc-device/source/codegen/metadata/nirfmxspecan/ and built grpc-device successfully.
Manually inspected nirfmxspecan.proto file.
Copied files from grpc-device-scrapigen/out/rfmxlte/export/ to grpc-device/source/codegen/metadata/nirfmxlte/ and built grpc-device successfully.
Manually inspected nirfmxlte.proto file.
Copied files from grpc-device-scrapigen\out\rfmxbluetooth\export to grpc-device/source/codegen/metadata/ nirfmxbluetooth / and built grpc-device successfully.
Manually inspected nirfmxbluetooth.proto file.
Copied files from grpc-device-scrapigen\out\rfmxnr\export to grpc-device/source/codegen/metadata/ nirfmxnr/ and built grpc-device successfully.
Manually inspected nirfmxnr.proto file.
Copied files from grpc-device-scrapigen\out\rfmxwlan\export to grpc-device/source/codegen/metadata/ nirfmxwlan/ and built grpc-device successfully.
Manually inspected nirfmxwlan.proto file.
Manually inspected nirfmxbluetooth.proto file.