Clean up exceptions in DAQ betterproto examples #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fix DAQ
betterproto
examples to print better exceptions, especially in common error cases.Note that
betterproto
does not reportGRPCError
s for connection failures. Those are reported asOSError
orTimeouError
, which do not provide much structure.Sample output:
Connection errors (different cases):
UNIMPLEMENTED error:
Other GRPC error:
Error from DAQ/
raise_if_error
:Why should this Pull Request be merged?
Simple implementation to provide reasonable errors for betterproto examples.
What testing has been done?
Ran examples in various success and failure cases.