Generate custom message types in proto file #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astarche
commented
Oct 7, 2021
reckenro
reviewed
Oct 8, 2021
reckenro
approved these changes
Oct 8, 2021
astarche
added
the
binary-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
This fixes codegen of several types in nidaqmx that were capitalized counter to proto style rules. See change to
nidaqmx.proto. This does not break existing generated clients, but calling code will have to be updated after the nextprotoc.Affected messages:
AnalogPowerUpChannelsAndStateWatchdogExpChannelsAndStateDigitalPowerUpTypeAndChannelDigitalPowerUpChannelsAndStateDigitalPullUpPullDownChannelsAndStateAnalogPowerUpChannelAndTypeWhat does this Pull Request accomplish?
Auto-generate the custom messages from
config.pyinstead of relying on duplicate definitions incustom_proto.mako.Remove
custom_proto.makofiles that previously contained custom messages.Fix-up some codegen that was incorrectly using camel-case for field names (and codegen that was compensating for that).
Why should this Pull Request be merged?
Encoding both was tedious and was hiding a bug in field casing.
What testing has been done?
Ran and passed all unit and integration tests. Ran and passed a cross-section of system tests.