Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dc power and xnetxocket enums. #665

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

reckenro
Copy link
Collaborator

@reckenro reckenro commented Jun 1, 2022

What does this Pull Request accomplish?

DCPower:

  • Event enum referenced by WaitForEvent and WaitForEventWithChannels
  • SendSoftwareEdgeTriggerType enum referenced by SendSoftwareEdgeTrigger and SendSoftwareEdgeTriggerWithChannels
  • SessionState enum removed from metadata. Couldn't find any reference to it or its values anywhere, including header file.

XNETSocket:

  • ProtocolFamily enum removed from metadata. It could arguably be used for domain param of nxsocket instead of AddressFamily enum but their values match, are often used interchangeably in implementations, and AddressFamily (nxAF _INET) is what's referenced in the documentation.

Why should this Pull Request be merged?

Addresses the 3 enums in dc power not included in proto and 1 enum in xnetsocket not in the proto.

AB#1991309
AB#1991312

What testing has been done?

Visual inspection of generated proto files. Relying on unit tests since functions now referencing enums aren't used in system tests or examples.

@reckenro reckenro added the binary-breaking Change to proto file that requires client updates label Jun 1, 2022
@reckenro
Copy link
Collaborator Author

reckenro commented Jun 1, 2022

Note: Marking breaking change as the client will need to update the enum their using for the updated DC Power functions.

@reckenro
Copy link
Collaborator Author

reckenro commented Jun 7, 2022

@mgumble , same as the FGEN enum one. Pretty straightforward so I'm going to remove you but feel free to come back to it if you want when you get back.

@reckenro reckenro merged commit 644d542 into ni:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary-breaking Change to proto file that requires client updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants