Fix missing fgen and switch enums. #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reckenro
added
the
binary-breaking
reckenro
changed the title
reckenro
changed the title
|
Note: Marked breaking-change because it would break FGEN callers of |
astarche
approved these changes
Jun 3, 2022
|
@mgumble , I'm going to submit this one since it's pretty straightforward. Feel free to come back to it after you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
FGEN:
TriggerWhenenum now referenced byConfigureDigitalLevelScriptTriggerRequestTriggerWhen param. This lines up with values mentioned in documentation and matches values I found used in .NET implementation.UpdateClockSourceenum removed from metadata. Would be used in obsoleteNIFGEN_ATTR_UPDATE_CLOCK_SOURCEattribute but we didn't bring that in to grpc-device.Switch:
CabledModuleScanAdvancedBus,CabledModuleTriggerBus,MasterSlaveScanAdvancedBus,MasterSlaveTriggerBus, andTriggerModeenums removed from metadata. These would be referenced by obsolete attributesNISWITCH_ATTR_CABLED_MODULE_SCAN_ADVANCED_BUS,NISWITCH_ATTR_CABLED_MODULE_TRIGGER_BUS,NISWITCH_ATTR_MASTER_SLAVE_SCAN_ADVANCED_BUS.NISWITCH_ATTR_MASTER_SLAVE_TRIGGER_BUS, andNISWITCH_ATTR_TRIGGER_MODEbut we didn't bring any of them into grpc-device.Why should this Pull Request be merged?
Two enums in FGEN and five in Switch weren't being generated in proto.
AB#1991311
AB#1991321
What testing has been done?
Visual inspection of updated proto file. Relying on unit tests, otherwise, since the functions updated aren't referenced in system level tests or examples.